feat: add warning in dev mode when method is not function (#… #8022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
posva
requested changes
Apr 13, 2018
src/core/instance/state.js
Outdated
| @@ -273,6 +273,11 @@ function initMethods (vm: Component, methods: Object) { | |||
| `Avoid defining component methods that start with _ or $.` | |||
| ) | |||
| } | |||
| if (typeof methods[key] !== 'function') { | |||
There was a problem hiding this comment.
Could you make this test in development mode only and add a test (or/and adapt existing one), please?
…void runtime error
posva
requested changes
Apr 14, 2018
posva
approved these changes
Apr 14, 2018
ulivz
reviewed
Apr 15, 2018
lusarz
reviewed
Apr 17, 2018
|
A check and a warning already exists for this in the block directly above the one added by this PR. |
|
that's sad. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8017
add warning in dev mode when method is not function
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If adding a new feature, the PR's description includes:
Other information: